From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Run a portal's cleanup hook immediately when pushing it to DONE |
Date: | 2011-03-03 18:04:20 |
Message-ID: | E1PvCsu-0006YE-Be@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Run a portal's cleanup hook immediately when pushing it to DONE state.
This works around the problem noted by Yamamoto Takashi in bug #5906,
that there were code paths whereby we could reach AtCleanup_Portals
with a portal's cleanup hook still unexecuted. The changes I made
a few days ago were intended to prevent that from happening, and
I think that on balance it's still a good thing to avoid, so I don't
want to remove the Assert in AtCleanup_Portals. Hence do this instead.
Branch
------
master
Details
-------
http://git.postgresql.org/pg/commitdiff/6252c4f9e201f619e5eebda12fa867acd4e4200e
Modified Files
--------------
src/backend/tcop/pquery.c | 2 +-
src/backend/utils/mmgr/portalmem.c | 26 ++++++++++++++++++++++++++
src/include/utils/portal.h | 1 +
3 files changed, 28 insertions(+), 1 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2011-03-03 18:22:34 | pgsql: Fix citext's upgrade-from-unpackaged script to set its collation |
Previous Message | Michael Meskes | 2011-03-03 12:45:12 | pgsql: Added new version of ecpg's parser generator script. This one wa |