pgsql: Code review for postmaster.pid contents changes.

Code review for postmaster.pid contents changes.

Fix broken test for pre-existing postmaster, caused by wrong code for
appending lines to the lockfile; don't write a failed listen_address
setting into the lockfile; don't arbitrarily change the location of the
data directory in the lockfile compared to previous releases; provide more
consistent and useful definitions of the socket path and listen_address
entries; avoid assuming that pg_ctl has the same DEFAULT_PGSOCKET_DIR as
the postmaster; assorted code style improvements.

Branch
------
master

Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=52948169bcddf443b76d6ff1806259b153a2ac04

Modified Files
--------------
doc/src/sgml/storage.sgml | 11 ++-
src/backend/port/ipc_test.c | 4 +-
src/backend/port/sysv_shmem.c | 13 ++-
src/backend/postmaster/postmaster.c | 35 ++++---
src/backend/utils/init/miscinit.c | 77 ++++++++-------
src/bin/pg_ctl/pg_ctl.c | 185 ++++++++++++++++++-----------------
src/include/miscadmin.h | 28 +++++-
7 files changed, 194 insertions(+), 159 deletions(-)