From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)postgresql(dot)org |
Subject: | pgsql: Clean up some copied-and-pasted code in pg_upgrade. |
Date: | 2010-12-11 19:18:06 |
Message-ID: | E1PRUxK-0002Hk-Pq@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Clean up some copied-and-pasted code in pg_upgrade.
1. Don't reimplement S_ISDIR() and S_ISREG() badly.
2. Don't reimplement access() badly.
This code appears to have been copied from ancient versions of the
corresponding backend routines, and not patched to incorporate subsequent
fixes (see my commits of 2008-03-31 and 2010-01-14 respectively).
It might be a good idea to change it to just *call* those routines,
but for now I'll just transpose these fixes over.
Branch
------
master
Details
-------
http://git.postgresql.org/gitweb?p=postgresql.git;a=commitdiff;h=3864afa1d1478f7a76fde1ea160a7bc8f5d5b203
Modified Files
--------------
contrib/pg_upgrade/exec.c | 69 +++-----------------------------------------
contrib/pg_upgrade/file.c | 4 +-
2 files changed, 7 insertions(+), 66 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2010-12-11 21:03:23 | Re: [COMMITTERS] pgsql: Reduce spurious Hot Standby conflicts from never-visible records |
Previous Message | Tom Lane | 2010-12-11 18:11:29 | pgsql: Provide a complete set of file-permission-bit macros in win32.h. |