pgsql: Force default wal_sync_method to be fdatasync on Linux.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Force default wal_sync_method to be fdatasync on Linux.
Date: 2010-12-09 01:02:29
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-committers

Force default wal_sync_method to be fdatasync on Linux.

Recent versions of the Linux system header files cause xlogdefs.h to
believe that open_datasync should be the default sync method, whereas
formerly fdatasync was the default on Linux. open_datasync is a bad
choice, first because it doesn't actually outperform fdatasync (in fact
the reverse), and second because we try to use O_DIRECT with it, causing
failures on certain filesystems (e.g., ext4 with data=journal option).
This part of the patch is largely per a proposal from Marti Raudsepp.
More extensive changes are likely to follow in HEAD, but this is as much
change as we want to back-patch.

Also clean up confusing code and incorrect documentation surrounding the
fsync_writethrough option. Those changes shouldn't result in any actual
behavioral change, but I chose to back-patch them anyway to keep the
branches looking similar in this area.

In 9.0 and HEAD, also do some copy-editing on the WAL Reliability
documentation section.

Back-patch to all supported branches, since any of them might get used
on modern Linux versions.



Modified Files
doc/src/sgml/config.sgml | 8 +++++---
src/backend/access/transam/xlog.c | 10 +++++-----
src/backend/storage/file/fd.c | 9 +++++----
src/backend/utils/misc/postgresql.conf.sample | 2 +-
src/include/port/linux.h | 10 ++++++++++
src/include/port/win32.h | 14 +++++++++-----
6 files changed, 35 insertions(+), 18 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Simon Riggs 2010-12-09 09:45:11 pgsql: Reduce spurious Hot Standby conflicts from never-visible records
Previous Message Greg Smith 2010-12-08 22:43:29 Re: [COMMITTERS] pgsql: Optimize commit_siblings in two ways to improve group commit.