Re: meson: Make test output much more useful on failure (both in CI and locally)

From: "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl>
To: "Corey Huinker" <corey(dot)huinker(at)gmail(dot)com>
Cc: "Zsolt Parragi" <zsolt(dot)parragi(at)percona(dot)com>, "Nazir Bilal Yavuz" <byavuz81(at)gmail(dot)com>, "Andres Freund" <andres(at)anarazel(dot)de>, "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, <andrew(at)dunslane(dot)net>
Subject: Re: meson: Make test output much more useful on failure (both in CI and locally)
Date: 2026-03-20 08:19:19
Message-ID: DH7GNPMENGF5.3HICJRPB9KQWO@jeltef.nl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu Mar 19, 2026 at 8:44 PM CET, Corey Huinker wrote:
>>
>>
>> Finally I added a new commit which starts to use command_ok in
>> 002_pg_upgrade.pl and 027_stream_regress.pl to get the new nicer output.
>>
>
> I tried this out, and am very pleased with the results.

Thanks for the review.

> nitpick: comment sentence needs a closing '.'

Fixed

> v4-0005: the commit message is probably too bulky to be used as-is, but the
> committer was going to change that anyway and right now too much
> information is way better than not enough.

Shortened it using your example run.

> I can't wait to use this.

Me too :) I've also added the Author/Reviewed-By/Discussion footers to
the commits to make the committers job easier.

Attachment Content-Type Size
v5-0001-pg_regress-Include-diffs-in-output.patch text/x-patch 6.6 KB
v5-0002-perl-tap-Show-failed-command-output.patch text/x-patch 4.6 KB
v5-0003-perl-tap-Show-die-reason-in-TAP-output.patch text/x-patch 2.7 KB
v5-0004-perl-tap-Use-croak-instead-of-die-in-our-perl-hel.patch text/x-patch 18.5 KB
v5-0005-Simplify-and-improve-output-of-002_pg_upgrade.pl-.patch text/x-patch 6.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2026-03-20 08:20:04 Re: Eliminating SPI / SQL from some RI triggers - take 3
Previous Message jian he 2026-03-20 08:15:12 Re: CAST(... ON DEFAULT) - WIP build on top of Error-Safe User Functions