Re: Add GoAway protocol message for graceful but fast server shutdown/switchover

From: "Jelte Fennema-Nio" <postgres(at)jeltef(dot)nl>
To: "Zsolt Parragi" <zsolt(dot)parragi(at)percona(dot)com>
Cc: "PostgreSQL Hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "Dave Cramer" <davecramer(at)gmail(dot)com>, "Jacob Champion" <jacob(dot)champion(at)enterprisedb(dot)com>, "Heikki Linnakangas" <hlinnaka(at)iki(dot)fi>
Subject: Re: Add GoAway protocol message for graceful but fast server shutdown/switchover
Date: 2026-03-13 09:39:39
Message-ID: DH1JZEYZOBSW.1QEY6MI45FCIL@jeltef.nl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed Feb 25, 2026 at 4:08 PM CET, Zsolt Parragi wrote:
> + /*
> + * Only signal regular backends, since those need to notify
> + * their clients using a GoAway message.
> + */
> + if (bp->bkend_type == B_BACKEND)
>
> This condition is slightly different to how SignalChildren works, is
> that intentional? I don't think it causes any practical difference,
> and I don't see an easy way to reuse SignalChildren for this, but
> maybe it could still follow the same pattern.

Changed it to be consistent now, and resolved a rebase conflict.

> Since the pytest framework seems unlikely to be included in PG19, have
> you considered a different test implementation, to have at least some
> minimal coverage?

I now included some basic support for GoAway in psql and added a perl
test based on that.

Attachment Content-Type Size
v7-0001-Add-GoAway-protocol-message-for-graceful-but-fast.patch text/x-patch 26.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2026-03-13 09:51:34 Re: Skipping schema changes in publication
Previous Message Andrei Lepikhov 2026-03-13 09:31:53 Re: Vacuum statistics