Re: TestLib condition for deleting temporary directories

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: TestLib condition for deleting temporary directories
Date: 2020-02-02 17:19:04
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On 2 Feb 2020, at 18:01, Noah Misch <noah(at)leadboat(dot)com> wrote:
> Forking thread "logical decoding : exceeded maxAllocatedDescs for .spill
> files" for this side issue:

Thanks, I hadn't seen this.

> On Wed, Jan 08, 2020 at 09:37:04PM -0800, Noah Misch wrote:
>> v10
>> deletes PostgresNode base directories at the end of this test file, despite
>> the failure[1].
>> [1] It has the all_tests_passing() logic in an attempt to stop this. I'm
>> guessing it didn't help because the file failed by calling die "connection
>> error: ...", not by reporting a failure to Test::More via ok(0) or similar.
> That is what happened. We should test the exit status to decide whether to
> keep temporaries, as attached. PostgresNode does that, since commit 90627cf
> (thread That
> thread already discussed $SUBJECT[1] and the __DIE__ handler being
> redundant[2]. I plan to back-patch, since it's most useful for v10 and v9.6.

I'm travelling and haven't been able to test, but this makes sense from
reading. +1 on backpatching.

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Adé 2020-02-02 18:06:01 [PATCH] Fix for slow GIN index queries when "gin_fuzzy_search_limit" setting is relatively small for large tables
Previous Message Noah Misch 2020-02-02 17:01:55 TestLib condition for deleting temporary directories