| From: | "Imseih (AWS), Sami" <simseih(at)amazon(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add index scan progress to pg_stat_progress_vacuum |
| Date: | 2022-03-12 07:00:06 |
| Message-ID: | DD7EEE19-EFFB-481C-A6EC-26B1E0356F7A@amazon.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> nitpick: Can we remove the extra spaces in the parentheses?
fixed
> What does it mean if there isn't an entry in the map? Is this actually
> expected, or should we ERROR instead?
I cleaned up the code here and added comments.
> I think the number of entries should be shared between
> VacuumWorkerProgressShmemInit() and VacuumWorkerProgressShmemSize().
> Otherwise, we might update one and not the other.
Fixed
> I think we should elaborate a bit more in this comment. It's difficult to
> follow what this is doing without referencing the comment above
> set_vacuum_worker_progress().
More comments added
I also simplified the 0002 patch as well.
--
Sami Imseih
Amazon Web Services
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Show-progress-for-index-vacuums.patch | application/octet-stream | 18.9 KB |
| v5-0002-Expose-indexes-being-processed-in-a-VACUUM-operat.patch | application/octet-stream | 16.7 KB |
| v5-0003-Rename-index_vacuum_count-in-pg_stat_pogress_vacu.patch | application/octet-stream | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2022-03-12 07:29:08 | Re: Printing backtrace of postgres processes |
| Previous Message | vignesh C | 2022-03-12 06:55:27 | Re: Handle infinite recursion in logical replication setup |