| From: | Christian Ullrich <chris(at)chrullrich(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: pgsql: Add putenv support for msvcrt from Visual Studio 2013 |
| Date: | 2016-11-30 16:24:34 |
| Message-ID: | DB6PR0602MB29818313F0C5DCD2C7C65DDED48C0@DB6PR0602MB2981.eurprd06.prod.outlook.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
* From: Michael Paquier
> With 0005 I am seeing a compilation failure: you need to have the
> declarations in the _MSC_VER block at the beginning of the routine. It
Sorry, too used to C++.
> would be nice to mention in a code comment that this what Noah has
> mentioned upthread: if a CRT loads while pgwin32_putenv() is
> executing, the newly-loaded CRT will always have the latest value.
I fixed the existing comment by removing the last sentence that is in the wrong place now, but I don't see the point in suddenly starting to explain why it is done this way and not the other.
> Based on that 0006 will need a rebase, nothing huge though.
Done, new revisions attached.
--
Christian
| Attachment | Content-Type | Size |
|---|---|---|
| 0005-Do-the-process-environment-update-first.patch | application/octet-stream | 3.3 KB |
| 0006-Fix-the-unload-race-as-best-we-can.patch | application/octet-stream | 4.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-11-30 17:30:09 | Re: Re: [COMMITTERS] pgsql: Build HTML documentation using XSLT stylesheets by default |
| Previous Message | Heikki Linnakangas | 2016-11-30 16:08:05 | pgsql: Make all unicode perl scripts to use strict, rearrange logic for |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | xu jian | 2016-11-30 16:33:06 | postgres 1 个(共 2 个) can pg 9.6 vacuum freeze skip page on index? |
| Previous Message | Andrew Dunstan | 2016-11-30 16:19:35 | Re: Mail thread references in commits |