| From: | "Albe Laurenz" <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
|---|---|
| To: | "Magnus Hagander *EXTERN*" <magnus(at)hagander(dot)net> |
| Cc: | <simon(at)2ndquadrant(dot)com>, <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Improve shutdown during online backup, take 3 |
| Date: | 2008-04-23 08:40:29 |
| Message-ID: | D960CB61B694CF459DCFB4B0128514C202043A03@exadv11.host.magwien.gv.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Magnus Hagander wrote:
> This doesn't look like our normal coding standards, and should probably
> be changed:
> + if (0 != stat(BACKUP_LABEL_FILE, &stat_buf))
>
> (there's a number of similar places)
Lacking guidelines, I now tried to copy how stat(2) is used in other parts
of the code.
Yours,
Laurenz Albe
| Attachment | Content-Type | Size |
|---|---|---|
| backup-shut.doc.patch | application/octet-stream | 3.2 KB |
| backup-shut.patch | application/octet-stream | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-04-23 08:43:23 | Re: Improve shutdown during online backup, take 4 |
| Previous Message | Simon Riggs | 2008-04-23 07:51:32 | Re: Snapshot management, final |