| From: | "Tristan Partin" <tristan(at)neon(dot)tech> |
|---|---|
| To: | "Peter Eisentraut" <peter(at)eisentraut(dot)org>, <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Clean up some signal usage mainly related to Windows |
| Date: | 2023-07-12 14:35:58 |
| Message-ID: | CU09P3FQ4JB4.T8AHOQWH22YA@gonk |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed Jul 12, 2023 at 9:31 AM CDT, Peter Eisentraut wrote:
> On 12.07.23 16:23, Tristan Partin wrote:
> > It has come to my attention that STDOUT_FILENO might not be portable and
> > fileno(3) isn't marked as signal-safe, so I have just used the raw 1 for
> > stdout, which as far as I know is portable.
>
> We do use STDOUT_FILENO elsewhere in the code, and there are even
> workaround definitions for Windows, so it appears it is meant to be used.
v3 is back to the original patch with newline being printed. Thanks.
--
Tristan Partin
Neon (https://neon.tech)
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Cleanup-some-signal-usage-on-Windows.patch | text/x-patch | 4.2 KB |
| v3-0001-Use-signal-safe-functions-in-signal-handler.patch | text/x-patch | 908 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-07-12 14:37:16 | RelationGetIndexAttrBitmap comment outdated |
| Previous Message | Peter Eisentraut | 2023-07-12 14:31:23 | Re: Clean up some signal usage mainly related to Windows |