Meson build updates

From: "Tristan Partin" <tristan(at)neon(dot)tech>
To: <pgsql-hackers(at)postgresql(dot)org>
Subject: Meson build updates
Date: 2023-05-18 15:36:59
Message-ID: CSPIJVUDZFKX.3KHMOAVGF94RV@c3po
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I took some time to look at the Meson build for Postgres. I contribute
some of the time to Meson, itself. Within this patchset you will find
pretty small changes. Most of the commits are attempting to create more
consistency with the surrounding code. I think there is more that can be
done to improve the build a bit like including subprojects for optional
dependencies like lz4, zstd, etc.

While I was reading through the code, I also noticed a few XXX/FIXMEs. I
don't mind taking a look at those in the future, but I think I need more
context for almost all of them since I am brand new to Postgres
development. Since I also have _some_ sway in the Meson community, I can
help get more attention to Meson issues that benefit Postgres. I
currently note 3 Meson issues that are commented in the code for
instance. If anyone ever has any problems or questions about Meson or
specifically the Meson build of Postgres, I am more than happy to
receive an email to see if I can help out.

Highlighting the biggest changes in this patchset:

- Add Meson overrides
- Remove Meson program options for specifying paths

Everything but the last patch could most likely be backported to
previous maintained releases including Meson, though the patchset is
initially targeting the master branch.

--
Tristan Partin
Neon (https://neon.tech)

Attachment Content-Type Size
v1-0001-Remove-triple-quoted-strings.patch text/x-patch 1.8 KB
v1-0002-Use-consistent-casing-in-Meson-option-description.patch text/x-patch 8.3 KB
v1-0003-Use-consistent-Meson-option-description-formats.patch text/x-patch 4.2 KB
v1-0004-Attach-colon-to-keyword-argument.patch text/x-patch 10.4 KB
v1-0005-Use-the-not_found_dep-constant.patch text/x-patch 887 bytes
v1-0006-Remove-old-comment.patch text/x-patch 844 bytes
v1-0007-Tie-adding-C-support-to-the-llvm-Meson-option.patch text/x-patch 1.7 KB
v1-0008-Mention-the-correct-way-to-disable-readline-suppo.patch text/x-patch 976 bytes
v1-0009-Remove-return-code-check.patch text/x-patch 952 bytes
v1-0010-Fix-some-grammar-usage-in-Meson-comments.patch text/x-patch 1.4 KB
v1-0011-Pass-feature-option-through-to-required-kwarg.patch text/x-patch 1.6 KB
v1-0012-Make-finding-pkg-config-python3-more-robust.patch text/x-patch 1.3 KB
v1-0013-Make-some-Meson-style-more-consistent-with-surrou.patch text/x-patch 3.7 KB
v1-0014-Reduce-branching-on-Meson-version.patch text/x-patch 1.9 KB
v1-0015-Use-a-better-error-message-in-an-impossible-case.patch text/x-patch 939 bytes
v1-0016-Add-Meson-overrides.patch text/x-patch 12.2 KB
v1-0017-Remove-Meson-program-options-for-specifying-paths.patch text/x-patch 6.7 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-05-18 15:47:17 Re: Possible regression setting GUCs on \connect
Previous Message Aleksander Alekseev 2023-05-18 15:27:22 Re: The documentation for READ COMMITTED may be incomplete or wrong