| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | jian he <jian(dot)universality(at)gmail(dot)com> |
| Cc: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Egor Rogov <e(dot)rogov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Soumyadeep Chakraborty <soumyadeep2007(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pg_stats and range statistics |
| Date: | 2023-11-25 16:55:11 |
| Message-ID: | CAPpHfdvu3w-MWcSXPPrBx1z5QTjSV-=Jm3xueAGzwjB7bLyvpQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 25, 2023 at 10:58 AM jian he <jian(dot)universality(at)gmail(dot)com> wrote:
> On Sat, Nov 25, 2023 at 7:06 AM Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > Hi!
> > Additionally, I found that the current patch can't handle infinite
> > range bounds and discards information about inclusiveness of range
> > bounds. The infinite bounds could be represented as NULL (while I'm
> > not sure how good this representation is). Regarding inclusiveness, I
> > don't see the possibility to represent them in a reasonable way within
> > an array of base types. I also don't feel good about discarding the
> > accuracy in the pg_stats view.
> >
>
> in range_length_histogram, maybe we can document that when calculating
> the length of a range, inclusiveness will be true.
I've revised the patchset. Edited comment in pg_statistic.h as you
proposed. And I've added to the documentation a short note on how the
range length histogram is calculated.
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Update-comments-for-pg_statistic-catalog--20231125-2.patch | application/octet-stream | 1.9 KB |
| 0002-Display-length-and-bounds-histograms-in-p-20231125-2.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2023-11-25 16:57:19 | Re: pg_stats and range statistics |
| Previous Message | Bruce Momjian | 2023-11-25 16:49:16 | Re: [HACKERS] Changing references of password encryption to hashing |