Re: Fix bloom WAL tap test

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix bloom WAL tap test
Date: 2017-11-09 10:51:07
Message-ID: CAPpHfdveUBbkmNn-R1aNbW49LHbqyvZ6s6x3RJkmovZY8BEe+Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On Wed, Nov 8, 2017 at 5:46 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
wrote:

> > So I think
> > that you should instead do something like that:
> >
> > --- a/contrib/bloom/Makefile
> > +++ b/contrib/bloom/Makefile
> > @@ -20,5 +20,12 @@ include $(top_builddir)/src/Makefile.global
> > include $(top_srcdir)/contrib/contrib-global.mk
> > endif
> >
> > +installcheck: wal-installcheck
> > +
> > +check: wal-check
> > +
> > +wal-installcheck:
> > + $(prove_installcheck)
> > +
> > wal-check: temp-install
> > $(prove_check)
> >
> > This works for me as I would expect it should.
>
> Looks good to me too.

OK, then so be it :)

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
wal-check-on-bloom-check-3.patch application/octet-stream 618 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message amul sul 2017-11-09 11:05:03 Re: path toward faster partition pruning
Previous Message Michael Paquier 2017-11-09 09:58:36 Re: (spelling) Ensure header of postgresql.auto.conf is consistent