| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Alexander Pyhalov <a(dot)pyhalov(at)postgrespro(dot)ru> |
| Cc: | Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>, Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Subject: | Re: Asynchronous MergeAppend |
| Date: | 2026-03-30 01:20:41 |
| Message-ID: | CAPpHfdu+3Eud0CBpdFT+osWiT=e=zOQUtBsx8Z5okKrqhgVAJg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi!
On Wed, Mar 18, 2026 at 8:17 AM Alexander Pyhalov
<a(dot)pyhalov(at)postgrespro(dot)ru> wrote:
> Alexander Pyhalov писал(а) 2026-03-02 09:44:
> > Alexander Pyhalov писал(а) 2026-02-12 10:08:
> >> Alexander Pyhalov писал(а) 2025-12-30 22:04:
> >>> Matheus Alcantara писал(а) 2025-12-30 18:04:
> >>>> On Tue Dec 30, 2025 at 10:15 AM -03, Alexander Pyhalov wrote:
> >>>>> Looks good. What do you think about
> >>>>> classify_matching_subplans_common()?
> >>>>> Should it stay where it is or should we hide it to
> >>>>> src/include/executor/execAppend.h ?
> >>>>>
> >>>> Yeah, sounds better to me to move classify_matching_subplans_common
> >>>> to
> >>>> execAppend.h since it very specific for the MergeAppend and Append
> >>>> execution. I've declared the function as static inline on
> >>>> execAppend.h
> >>>> but I'm not sure if it's the best approach.
> >>>>
> >>>> I've also wrote a proper commit message for this new version.
> >>>
> >>> Looks good to me.
> >>
> >> Hi.
> >> Rebased patches over fresh master.
> >
> > Hi.
> > Rebased patches over fresh master.
>
> Hi.
> Rebased patches over fresh master.
Thank you for your work on this subject.
I have revised the patchset. I think it would be better if common
infrastructure goes first. Otherwise we commit async merge append and
immediately revise it. I also did some minor improvements.
------
Regards,
Alexander Korotkov
Supabase
| Attachment | Content-Type | Size |
|---|---|---|
| v16-0001-mark_async_capable-subpath-should-match-subplan.patch | application/octet-stream | 2.7 KB |
| v16-0003-MergeAppend-should-support-Async-Foreign-Scan-su.patch | application/octet-stream | 42.7 KB |
| v16-0002-Common-infrastructure-to-MergeAppend-and-Append-.patch | application/octet-stream | 79.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2026-03-30 01:30:00 | Re: Avoid multiple SetLatch() calls in procsignal_sigusr1_handler() |
| Previous Message | Amit Langote | 2026-03-30 01:16:02 | Re: Add comments about fire_triggers argument in ri_triggers.c |