|From:||Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>|
|Subject:||Re: Fix bloom WAL tap test|
|Views:||Raw Message | Whole Thread | Download mbox|
On Wed, Sep 6, 2017 at 4:08 PM, Alexander Korotkov <
> I just realized that these lines of contrib/bloom/t/001_wal.pl don't
> check that queries give same results on master and standby. They just
> check that *return codes* of psql are equal.
> # Run test queries and compare their result
>> my $master_result = $node_master->psql("postgres", $queries);
>> my $standby_result = $node_standby->psql("postgres", $queries);
>> is($master_result, $standby_result, "$test_name: query result matches");
> Attached patch fixes this problem by using safe_psql() which returns psql
> output instead of return code. For safety, this patch replaces psql() with
> safe_psql() in other places too.
> I think this should be backpatched to 9.6 as bugfix.
Also, it would be nice to call wal-check on bloom check (now wal-check
isn't called even on check-world).
See attached patch. My changes to Makefile could be cumbersome. Sorry for
that, I don't have much experience with them...
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
|Next Message||Robert Haas||2017-09-06 14:43:39||Re: PoC plpgsql - possibility to force custom or generic plan|
|Previous Message||Alvaro Herrera||2017-09-06 13:52:05||Re: Rewriting the test of pg_upgrade as a TAP test|