Fix bloom WAL tap test

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Fix bloom WAL tap test
Date: 2017-09-06 13:08:07
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers


I just realized that these lines of contrib/bloom/t/ don't check
that queries give same results on master and standby. They just check that
*return codes* of psql are equal.

# Run test queries and compare their result
> my $master_result = $node_master->psql("postgres", $queries);
> my $standby_result = $node_standby->psql("postgres", $queries);
> is($master_result, $standby_result, "$test_name: query result matches");

Attached patch fixes this problem by using safe_psql() which returns psql
output instead of return code. For safety, this patch replaces psql() with
safe_psql() in other places too.

I think this should be backpatched to 9.6 as bugfix.

Alexander Korotkov
Postgres Professional:
The Russian Postgres Company

Attachment Content-Type Size
fix-bloom-wal-check.patch application/octet-stream 3.0 KB


Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-09-06 13:14:01 Re: [COMMITTERS] pgsql: Add psql variables showing server version and psql version.
Previous Message Peter Eisentraut 2017-09-06 13:05:21 Re: Rewriting the test of pg_upgrade as a TAP test