Re: Memory unit GUC range checks

On Wed, May 16, 2018 at 3:49 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:

> On 16/05/18 15:19, Heikki Linnakangas wrote:
>
>> $ postmaster -c track_activity_query_size=1024TB
>> FATAL: invalid value for parameter "track_activity_query_size": "1024TB"
>> HINT: Valid units for this parameter are "kB", "MB", "GB", and "TB".
>>
>> ...
>>
>> The HINT in the last message seems wrong: the hint claims that "TB" is
>> accepted, yet "1024 TB" was not accepted. And shouldn't the hint also
>> mention "B", since we accept that now?
>>
>>
>> Testing a setting with GUC_UNIT_KB:
>>
>> $ postmaster -c work_mem=102400B
>> FATAL: invalid value for parameter "work_mem": "100000B"
>> HINT: Valid units for this parameter are "kB", "MB", "GB", and "TB".
>>
>> This time the hint is accurate, but why is "B" not accepted here? Seems
>> inconsistent.
>>
>
> Here's a pretty straightforward fix for these two issues. Any objections
> or better ideas?

This patch looks good for me.
But I would also like to see units in valid range message (as I wrote in
previous email).

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company