| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Steve Chavez <steve(at)supabase(dot)io> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add red-black tree missing comparison searches |
| Date: | 2022-07-06 18:53:41 |
| Message-ID: | CAPpHfdsuMK0R0FKga+UbJs9Ni_gO5tRAm_EJ=e4KJhWuatuq2A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Steve!
On Sat, Jul 2, 2022 at 10:38 PM Steve Chavez <steve(at)supabase(dot)io> wrote:
> > But I think we can support strict inequalities too (e.g.
> less and greater without equals). Could you please make it a bool
> argument equal_matches?
>
> Sure, an argument is a good idea to keep the code shorter.
>
> > Could you please extract this change as a separate patch.
>
> Done!
Thank you!
I did some improvements to the test suite, run pgindent and wrote
commit messages.
I think this is quite straightforward and low-risk patch. I'm going
to push it if no objections.
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Use-C99-designator-in-the-rbtree-sentinel-definit-v2.patch | application/octet-stream | 728 bytes |
| 0002-Add-missing-inequality-searches-to-rbtree-v2.patch | application/octet-stream | 7.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-07-06 19:20:47 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |
| Previous Message | Matthias van de Meent | 2022-07-06 18:35:17 | Re: Make name optional in CREATE STATISTICS |