Re: ALTER INDEX .. SET STATISTICS ... behaviour

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Adrien Nayrat <adrien(dot)nayrat(at)dalibo(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER INDEX .. SET STATISTICS ... behaviour
Date: 2017-09-04 16:16:00
Message-ID: CAPpHfdsosY8cDnFG5UJk+bfiQLGgidRkuxVxzoN3kfPq_6-i6g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Hi, Adrien!

On Mon, Sep 4, 2017 at 3:57 PM, Adrien Nayrat <adrien(dot)nayrat(at)dalibo(dot)com>
wrote:

> On 08/30/2017 02:26 PM, Alexander Korotkov wrote:
> I reviewed this patch. It works as expected but I have few remarks :
>

Thank you for reviewing my patch!.

> * There is a warning during compilation :
>
> gram.y: In function ‘base_yyparse’:
> gram.y:2090:6: warning: ISO C90 forbids mixed declarations and code
> [-Wdeclaration-after-statement]
> AlterTableCmd *n = makeNode(AlterTableCmd);
> ^~~~~~~~~~~~~
>

Fixed.

> If I understand we should declare AlterTableCmd *n [...] before "if"?
>
> * I propose to add "Stats target" information in psql verbose output
> command
> \d+ (patch attached with test)
>
> \d+ tmp_idx
> Index "public.tmp_idx"
> Column | Type | Definition | Storage | Stats target
> --------+------------------+------------+---------+--------------
> a | integer | a | plain |
> expr | double precision | (d + e) | plain | 1000
> b | cstring | b | plain |
> btree, for table "public.tmp"
>
>
> * psql completion is missing (added to previous patch)
>

Looks good for me. I've integrated those changes in the patch.
New revision is attached.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
alter-index-statistics-3.patch application/octet-stream 20.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kuzmenkov 2017-09-04 16:17:42 Re: index-only count(*) for indexes supporting bitmap scans
Previous Message Alexander Korotkov 2017-09-04 16:06:55 Re: WIP: long transactions on hot standby feedback replica / proof of concept