Re: [PATCH] Incremental sort (was: PoC: Partial sort)

From: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
To: Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date: 2017-03-20 09:33:26
Message-ID: CAPpHfdsnQXo+oNBbfDrnMOr_P2GsBJ-zxf6qkotUV7bQRHisUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Dear Mithun,

On Mon, Mar 20, 2017 at 10:01 AM, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>
wrote:

> On Mon, Feb 27, 2017 at 8:29 PM, Alexander Korotkov
> <a(dot)korotkov(at)postgrespro(dot)ru> wrote:
>
> This patch needs to be rebased.
>
> 1. It fails while applying as below
>
> patching file src/test/regress/expected/sysviews.out
> Hunk #1 FAILED at 70.
> 1 out of 1 hunk FAILED -- saving rejects to file
> src/test/regress/expected/sysviews.out.rej
> patching file src/test/regress/sql/inherit.sql
>
> 2. Also, there are compilation errors due to new commits.
>
> -fwrapv -fexcess-precision=standard -O2 -I../../../../src/include
> -D_GNU_SOURCE -c -o createplan.o createplan.c
> createplan.c: In function ‘create_gather_merge_plan’:
> createplan.c:1510:11: warning: passing argument 3 of ‘make_sort’ makes
> integer from pointer without a cast [enabled by default]
> gm_plan->nullsFirst);
> ^
> createplan.c:235:14: note: expected ‘int’ but argument is of type
> ‘AttrNumber *’
> static Sort *make_sort(Plan *lefttree, int numCols, int skipCols,
> ^
> createplan.c:1510:11: warning: passing argument 4 of ‘make_sort’ from
> incompatible pointer type [enabled by default]
> gm_plan->nullsFirst);
>

Thank you for the report.
Please, find rebased patch in the attachment.

------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
incremental-sort-3.patch application/octet-stream 111.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-03-20 09:33:29 Re: Logical decoding on standby
Previous Message Craig Ringer 2017-03-20 09:31:53 Re: Logical decoding on standby