| From: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Alexander Kuzmenkov <a(dot)kuzmenkov(at)postgrespro(dot)ru>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Darafei Komяpa Praliaskouski <me(at)komzpa(dot)net>, Antonin Houska <ah(at)cybertec(dot)at>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] [PATCH] Incremental sort |
| Date: | 2018-04-07 16:23:21 |
| Message-ID: | CAPpHfdsn20cxCeO3pMEhgZpAYkHg1s_be6GS9-PP4Q0UxOnX7w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Apr 7, 2018 at 5:37 PM, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
> by this patch. Revised version is attached.
>>
>
> Fine, patch got several rounds of review in all its parts. Is any places
> which should be improved before commit?
Also I found that after planner changes of Alexander Kuzmenkov, incremental
sort
was used in cheapest_input_path() only if its child is cheapest total path.
That makes incremental sort to not get used almost never.
I've changed that to consider incremental sort path when we have some
presorted columns. I also have to put changes in postgres_fdw regression
tests back, because incremental sort was used right there.
This revision of the patch also includes commit message.
------
Alexander Korotkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| Attachment | Content-Type | Size |
|---|---|---|
| incremental-sort-26.patch | application/octet-stream | 99.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-04-07 16:23:46 | Re: [HACKERS] [PATCH] Incremental sort |
| Previous Message | Andres Freund | 2018-04-07 16:22:52 | Re: Online enabling of checksums |