| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Daniel Shelepanov <deniel1495(at)mail(dot)ru>, Nikita Malakhov <hukutoc(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de> |
| Subject: | Re: collect_corrupt_items_vacuum.patch |
| Date: | 2023-11-07 11:38:40 |
| Message-ID: | CAPpHfdsVVAdaGAJgoOBAJ+6EGaCdsUi=wbgQAc3+8X_qtUr=Qg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Alexander.
On Tue, Nov 7, 2023 at 1:00 PM Alexander Lakhin <exclusion(at)gmail(dot)com> wrote:
> It looks like the v2 patch doesn't fix the original issue. Maybe I miss
> something, but with the patch applied, I see the failure immediately,
> though without the patch several iterations are needed to get it.
That's a bug in the patch. Thank you for cathing it. It should start
calculation from latestCompletedXid + 1, not InvalidTransactionId.
Please, check the revised patch.
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-false-reports-in-pg_visibility-v3.patch | application/octet-stream | 4.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2023-11-07 11:43:18 | Re: Call pqPipelineFlush from PQsendFlushRequest |
| Previous Message | Dave Cramer | 2023-11-07 11:38:18 | Protocol question regarding Portal vs Cursor |