Re: WIP: index support for regexp search

From: Alexander Korotkov <aekorotkov(at)gmail(dot)com>
To: Marti Raudsepp <marti(at)juffo(dot)org>
Cc: Erik Rijkers <er(at)xs4all(dot)nl>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: WIP: index support for regexp search
Date: 2012-01-21 05:28:20
Message-ID: CAPpHfdsV2znvS-Lhv7_zck17KeGYoqMwr1DrC_6Pn2m__n4NLw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jan 20, 2012 at 8:45 PM, Marti Raudsepp <marti(at)juffo(dot)org> wrote:

> On Fri, Jan 20, 2012 at 01:33, Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> > Btw, it seems impossible to Ctrl-C out of a search once it is submitted;
> I suppose this is
> > normally necessary for perfomance reasons, but it would be useful te be
> able to compile a test
> > version that allows it.
>
> I believe being interruptible is a requirement for the patch to be
> accepted.
>
> CHECK_FOR_INTERRUPTS(); should be added to the indeterminate loops.
>
Sure. It's easy to fix. But it seems that in this case gin extract_query
method becomes slow (because index scan itself is breakable). So, it just
shouldn't work so long.

------
With best regards,
Alexander Korotkov.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2012-01-21 05:29:56 Re: WIP: index support for regexp search
Previous Message Alexander Korotkov 2012-01-21 05:26:36 Re: WIP: index support for regexp search