Re: [PATCH] Allow specification of custom slot for custom nodes

On Sat, Nov 26, 2022 at 2:05 PM Ian Lawrence Barwick <barwick(at)gmail(dot)com> wrote:
> 2022年11月22日(火) 5:50 Alexander Korotkov <aekorotkov(at)gmail(dot)com>:
> >
> > On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com> wrote:
> > > The following review has been posted through the commitfest application:
> > > make installcheck-world: tested, passed
> > > Implements feature: tested, passed
> > > Spec compliant: not tested
> > > Documentation: not tested
> > >
> > > I've looked at this patch and don't see any problems with it. It is minimally invasive, it doesn't affect functionality unless anyone (e.g. extension) sets its own slotOps in CustomScanState.
> > > Furthermore, the current patch very slightly modifies patch 0b03e5951bf0 with the intention of introducing extensibility. So I think adding more extensibility regarding different tuple formats is an excellent thing to do.
> > >
> > > I'm going to mark it as RfC if there are no objections.
> >
> > Thank you for your feedback. I also don't see how this patch could
> > affect anybody.
> > I'm going to push this if there are no objections.
>
> I see this was pushed (cee1209514) so have closed it in the CF app.

Yes, I forgot to do this. Thank you.

------
Regards,
Alexander Korotkov