| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Steve Chavez <steve(at)supabase(dot)io> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allow placeholders in ALTER ROLE w/o superuser |
| Date: | 2022-12-01 03:14:37 |
| Message-ID: | CAPpHfdsOrCp_TvfT=30fFkgREm9EKSsxTVjjtnTN8HpkXUTRtw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 23, 2022 at 1:53 AM Steve Chavez <steve(at)supabase(dot)io> wrote:
> So from my side this all looks good!
Thank you for your feedback.
The next revision of the patch is attached. It contains code
improvements, comments and documentation. I'm going to also write
sode tests. pg_db_role_setting doesn't seem to be well-covered with
tests. I will probably need to write a new module into
src/tests/modules to check now placeholders interacts with dynamically
defined GUCs.
------
Regards,
Alexander Korotkov
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-ALTER-ROLE-.-SET-.-TO-.-USER-SET-v2.patch | application/octet-stream | 21.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2022-12-01 04:32:40 | Re: pgsql: Revoke PUBLIC CREATE from public schema, now owned by pg_databas |
| Previous Message | David Rowley | 2022-12-01 02:58:23 | Re: Allow round() function to accept float and double precision |