| From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
| Cc: | Dmitry Koval <d(dot)koval(at)postgrespro(dot)ru>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix SPLIT PARTITION bound-overlap bug and other improvements |
| Date: | 2026-05-18 09:16:19 |
| Message-ID: | CAPpHfdsLnD3NGnPC32oeg4ZWWX441M=SfH0-7bG652G40TpEEQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 18, 2026 at 2:15 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> > On May 18, 2026, at 05:45, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > Hi, Chao!
> >
> > On Thu, May 14, 2026 at 9:59 AM Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> wrote:
> >> To make this patch easier to process, I split it into 4 commits:
> >>
> >> 0001 - Fixes the bound-overlap bug
> >> 0002 - Fix the incorrect HINT message for the DEFAULT case
> >> 0003 - Fix the incorrect description about combined bound in the SGML doc
> >> 0004 - Reject only-create-default-partition usage
> >
> > Thank you for your work. I've revised the patchset.
> > 0002 - I've also fixed gramma of hints in other branches
> > 0004 - In the check_split_partition_not_same_bound(), calling
> > partition_bounds_create() and partition_bounds_equal() looks a bit
> > heavyweight. It doesn't matter much performance-wise, but it feels
> > like start processing from scratch while we're on quite late stage
> > already. I've replaced that with more lightweight check. Also I
> > removed dealing with memory context. This code implies small
> > non-repetitive memory allocations which only lives during DDL
> > operation, no need to wrap them with memory context as we don't do so
> > in other places.
> >
> > Any objections if I commit this?
> >
> > ------
> > Regards,
> > Alexander Korotkov
> > Supabase
>
> Hi Alexander,
>
> Thanks for the revisions. I think you may have missed the attachments, so I cannot review the changes.
Sorry. Here it is.
------
Regards,
Alexander Korotkov
Supabase
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0003-Clarify-SPLIT-PARTITION-bound-requirements-in-doc.patch | application/octet-stream | 3.8 KB |
| v3-0001-Fix-SPLIT-PARTITION-range-bound-validation-with-D.patch | application/octet-stream | 4.1 KB |
| v3-0002-Fix-SPLIT-PARTITION-hint-for-DEFAULT-partition-bo.patch | application/octet-stream | 10.1 KB |
| v3-0004-Reject-degenerate-SPLIT-PARTITION-with-DEFAULT-pa.patch | application/octet-stream | 7.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vlad Lesin | 2026-05-18 10:11:56 | Re: [PATCH] Fix ProcKill lock-group vs procLatch recycle race |
| Previous Message | Nisha Moond | 2026-05-18 09:12:14 | Re: Proposal: Conflict log history table for Logical Replication |