From: | Alexander Korotkov <aekorotkov(at)gmail(dot)com> |
---|---|
To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
Subject: | Re: VM corruption on standby |
Date: | 2025-09-03 08:28:45 |
Message-ID: | CAPpHfdsCVYT32mFsGxf+cQMEoxqs2MYmKK8obtrX9VuEmjnJpw@mail.gmail.com |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Sep 3, 2025 at 9:47 AM Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
> > On 3 Sep 2025, at 11:37, Alexander Korotkov <aekorotkov(at)gmail(dot)com> wrote:
> >
> > Could you, please, recheck?
>
> That patch also adds CondVar sleep in critical section. That patch is how we understood that such sleep is dangerous.
>
> Actual patch to deteact a problem is much simpler:
> ```
> diff --git a/src/backend/storage/ipc/waiteventset.c
> b/src/backend/storage/ipc/waiteventset.c
> index 7c0e66900f9..e89e1d115cb 100644
> --- a/src/backend/storage/ipc/waiteventset.c
> +++ b/src/backend/storage/ipc/waiteventset.c
> @@ -1044,6 +1044,7 @@ WaitEventSetWait(WaitEventSet *set, long timeout,
> long cur_timeout = -1;
>
> Assert(nevents > 0);
> + Assert(CritSectionCount == 0);
>
> /*
> * Initialize timeout if requested. We must record the current time so
> ```
>
> Though it will fail in multixact test.
I thought that patch allows to reproduce the problem of bc22dc0e0d.
Sorry for the noise.
------
Regards,
Alexander Korotkov
Supabase
From | Date | Subject | |
---|---|---|---|
Next Message | jian he | 2025-09-03 08:30:54 | fix NOT VALID NOT NULL with ALTER COLUMN SET IDENTITY |
Previous Message | Dean Rasheed | 2025-09-03 07:34:45 | Re: Refactoring: Use soft error reporting for *_opt_error functions |