| From: | Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com> |
|---|---|
| To: | Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
| Cc: | Zhihong Yu <zyu(at)yugabyte(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, tanghy(dot)fnst(at)fujitsu(dot)com, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, houzj(dot)fnst(at)fujitsu(dot)com |
| Subject: | Re: Fast COPY FROM based on batch insert |
| Date: | 2022-10-12 02:56:17 |
| Message-ID: | CAPmGK16aE1oO-AP_rjGLc8yf_OK_eoF1mQqsHVEzFu2WptXLMQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 11, 2022 at 3:06 PM Andrey Lepikhov
<a(dot)lepikhov(at)postgrespro(dot)ru> wrote:
> I reviewed the patch one more time. Only one question: bistate and
> ri_FdwRoutine are strongly bounded. Maybe to add some assertion on
> (ri_FdwRoutine XOR bistate) ? Just to prevent possible errors in future.
You mean the bistate member of CopyMultiInsertBuffer?
We do not use that member at all for foreign tables, so the patch
avoids initializing that member in CopyMultiInsertBufferInit() when
called for a foreign table. So we have bistate = NULL for foreign
tables (and bistate != NULL for plain tables), as you mentioned above.
I think it is a good idea to add such assertions. How about adding
them to CopyMultiInsertBufferFlush() and
CopyMultiInsertBufferCleanup() like the attached? In the attached I
updated comments a bit further as well.
Thanks for reviewing!
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Implementation-of-a-Bulk-COPY-FROM-efujita-5.patch | application/octet-stream | 25.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-10-12 03:29:16 | Re: test_decoding assertion failure for the loss of top-sub transaction relationship |
| Previous Message | David Rowley | 2022-10-12 02:40:42 | Allow WindowFuncs prosupport function to use more optimal WindowClause options |