Re: Read access for pg_monitor to pg_replication_origin_status view

From: Martín Marqués <martin(at)2ndquadrant(dot)com>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Read access for pg_monitor to pg_replication_origin_status view
Date: 2020-06-02 16:13:18
Message-ID: CAPdiE1zJ_hn-ZyCw4kejSnpd7V2QqZ3pos4h6fd+vgA2Y=a_qw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Stephen,

> > I have no problem adding it to this ROLE, but we'd have to amend the
> > doc for default-roles to reflect that SELECT for this view is also
> > granted to `pg_read_all_stats`.
>
> I agree in general that pg_monitor shouldn't have privileges granted
> directly to it. If this needs a new default role, that's an option, but
> it seems like it'd make sense to be part of pg_read_all_stats to me, so
> amending the docs looks reasonable from here.

Good, that's more or less what I had in mind.

Here goes v2 of the patch, now there are 4 files (I could have
squashed the docs with the code changes, but hey, that'll be easy to
merge if needed :-) )

I did some fiddling to Michaels doc proposal, but it says basically the same.

Not 100% happy with the change to user-manag.sgml, but ok enough to send.

I also added an entry to the commitfest so we can track this there as well.

Regards,

--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
v2-0001-Access-to-pg_replication_origin_status-view-has-r.patch text/x-patch 3.0 KB
v2-0003-Change-replication-origin-function-documenation-t.patch text/x-patch 1.2 KB
v2-0002-We-want-the-monitoring-role-pg_read_all_stats-to-.patch text/x-patch 1.0 KB
v2-0004-Apply-changes-to-the-documentation-to-reflect-tha.patch text/x-patch 1.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2020-06-02 16:58:25 Re: Command statistics system (cmdstats)
Previous Message Stephen Frost 2020-06-02 15:11:11 Re: Read access for pg_monitor to pg_replication_origin_status view