Re: Extra Vietnamese unaccent rules

From: Man Trieu <man(dot)trieu(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Dang Minh Huong <kakalot49(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Kha Nguyen <nlhkha(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extra Vietnamese unaccent rules
Date: 2017-06-06 16:06:22
Message-ID: CAPaRaYojM-W+sTeECfrAy=7K4ZQqr_YH23pFYBdpxyE8SYuZXw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

2017-06-07 0:31 GMT+09:00 Bruce Momjian <bruce(at)momjian(dot)us>:

> On Wed, Jun 7, 2017 at 12:10:25AM +0900, Dang Minh Huong wrote:
> > > On Jun 4, 29 Heisei, at 00:48, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > >>>> Shouldn't you use "or is_letter_with_marks()", instead of "or
> len(...)
> > >>>>> 1"? Your test might catch something that isn't based on a 'letter'
> > >>>> (according to is_plain_letter). Otherwise this looks pretty good to
> > >>>> me. Please add it to the next commitfest.
> > >>>
> > >>> Thanks for confirm, sir.
> > >>> I will add it to the next CF soon.
> > >>
> > >> Sorry for lately response. I attach the update patch.
> > >
> > > Uh, there is no patch attached.
> > >
> >
> > Sorry sir, reattach the patch.
> > I also added it to the next CF and set reviewers to Thomas Munro. Could
> you confirm for me.
>
> There seems to be a problem. I can't see a patch dated 2017-06-07 on
> the commitfest page:
>
> https://commitfest.postgresql.org/14/1161/
>
> I added the thread but there was no change. (I think the thread was
> already present.) It appears it is not seeing this patch as the latest
> patch.
>
> Does anyone know why this is happening?
>

May be due to my Mac's mailer? Sorry but I try one more time to attach the
patch by webmail.

---
Thanks and best regards,
Dang Minh Huong

Attachment Content-Type Size
unaccent.patch application/octet-stream 4.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-06-06 16:08:50 Re: sketchy partcollation handling
Previous Message Kevin Hale Boyes 2017-06-06 15:37:10 Re: sketchy partcollation handling