| From: | Philip Alger <paalger0(at)gmail(dot)com> |
|---|---|
| To: | Yugo Nagata <nagata(at)sraoss(dot)co(dot)jp> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Improve coments on structures in trigger.c |
| Date: | 2025-10-06 02:38:21 |
| Message-ID: | CAPXBC8LWYqQ5bjt3pmjU93f_RWky=8B84X8ADKDbZeHBjfiZWw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Yugo,
> I found that comments in trigger.c describing fields of three different
> structures in a comment block.
That makes sense to me.
> I've attached a patch to improve the comments
> by splitting it to three blocks.
>
I think you could also move the comment beginning on:
* AfterTriggersData has the following fields:
To between:
typedef struct AfterTriggersTableData AfterTriggersTableData;
> HERE
typedef struct AfterTriggersData
To keep it consistent with the other comments you moved around.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-10-06 02:43:11 | Re: Improve read_local_xlog_page_guts by replacing polling with latch-based waiting |
| Previous Message | Michael Paquier | 2025-10-06 02:18:17 | Re: Refactoring: Use soft error reporting for *_opt_error functions |