Re: Constant Splitting/Refactoring

From: David Christensen <david(dot)christensen(at)crunchydata(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, peter(at)eisentraut(dot)org
Subject: Re: Constant Splitting/Refactoring
Date: 2024-03-13 15:42:19
Message-ID: CAOxo6XLh2eew1SkAkCShcPhXF3BCCWriPmy-atbZpb11h_0FjQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here is a version 2 of this patch, rebased atop 97d85be365.

As before, this is a cleanup/prerequisite patch series for the page
features/reserved page size patches[1]. (Said patch series is going
to be updated shortly.)

This splits each of the 4 constants that care about page size into
Cluster-specific and -Limit variants, the first intended to become a
variable in time, and the second being the maximum value such a
variable may take (largely used for static
allocations).

Since these patches define these symbols to have the same values they
previously had, there are no changes in functionality. These were
largely mechanical changes, and as such we should perhaps consider
making the same changes to back-branches to make it so context lines
and the like
would be the same, simplifying maintainer's efforts when applying code
in back branches that touch similar areas.

The script I have to make these changes is simple, and could be run
against the back branches with only the comments surrounding Calc()
pieces needing
to be adjusted once.

Thanks,

David

[1] https://commitfest.postgresql.org/47/3986/

Attachment Content-Type Size
v2-0001-Split-MaxHeapTuplesPerPage-into-runtime-and-max-v.patch application/octet-stream 24.5 KB
v2-0002-Split-MaxHeapTupleSize-into-runtime-and-max-value.patch application/octet-stream 9.7 KB
v2-0004-Split-MaxTIDsPerBTreePage-into-runtime-and-max-va.patch application/octet-stream 7.1 KB
v2-0003-Split-MaxIndexTuplesPerPage-into-runtime-and-max-.patch application/octet-stream 19.1 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bharath Rupireddy 2024-03-13 15:54:17 Re: Introduce XID age and inactive timeout based replication slot invalidation
Previous Message Dilip Kumar 2024-03-13 15:39:04 Re: BitmapHeapScan streaming read user and prelim refactoring