| From: | David Christensen <david(dot)christensen(at)crunchydata(dot)com> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |
| Date: | 2022-11-09 20:37:29 |
| Message-ID: | CAOxo6X+t9BfKLJ0FSC2fOHNh8icOZ=LBmrkm1HxRmZuLxLjLUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 9, 2022 at 2:08 PM David Christensen
<david(dot)christensen(at)crunchydata(dot)com> wrote:
> Justin sez:
> > I was wondering if there's any reason to do "CREATE DATABASE". The vast
> > majority of TAP tests don't.
> >
> > $ git grep -ho 'safe_psql[^ ]*' '*pl' |sort |uniq -c |sort -nr |head
> > 1435 safe_psql('postgres',
> > 335 safe_psql(
> > 23 safe_psql($connect_db,
>
> If there was a reason, I don't recall offhand; I will test removing it
> and if things still work will consider it good enough.
Things blew up when I did that; rather than hunt it down, I just left it in. :-)
Enclosed is v7, with changes thus suggested thus far.
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Teach-pg_waldump-to-extract-FPIs-from-the-WAL-str.patch | application/octet-stream | 17.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Wong | 2022-11-09 20:47:23 | Re: real/float example for testlibpq3 |
| Previous Message | Andres Freund | 2022-11-09 20:25:09 | Re: allow segment size to be set to < 1GiB |