| From: | David Christensen <david(dot)christensen(at)crunchydata(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |
| Date: | 2022-05-02 23:44:45 |
| Message-ID: | CAOxo6X+U7s-1uawfZQkW8iy_vNNcht0dVdYp9Z7=PxjMhdyNbg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
...and pushing a couple fixups pointed out by cfbot, so here's v4.
On Mon, May 2, 2022 at 8:42 AM David Christensen
<david(dot)christensen(at)crunchydata(dot)com> wrote:
>
> Enclosed is v3 of this patch; this adds two modes for this feature,
> one with the raw page `--save-fullpage/-W` and one with the
> LSN+checksum fixups `--save-fullpage-fixup/-X`.
>
> I've added at least some basic sanity-checking of the underlying
> feature, as well as run the test file and the changes to pg_waldump.c
> through pgindent/perltidy to make them adhere to project standards.
> Threw in a rebase as well.
>
> Would appreciate any additional feedback here.
>
> Best,
>
> David
| Attachment | Content-Type | Size |
|---|---|---|
| v4-pg_waldump-save-fpi.patch | application/octet-stream | 21.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan S. Katz | 2022-05-03 00:56:56 | PostgreSQL 15 Beta 1 release date |
| Previous Message | Nathan Bossart | 2022-05-02 23:06:13 | Re: avoid multiple hard links to same WAL file after a crash |