| From: | Maciek Sakrejda <m(dot)sakrejda(at)gmail(dot)com> |
|---|---|
| To: | Georgios Kokolatos <gkokolatos(at)pm(dot)me> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Duplicate Workers entries in some EXPLAIN plans |
| Date: | 2020-01-15 07:22:04 |
| Message-ID: | CAOtHd0CC1iVG0ZA08onswgiOU9++Qhec0WRtECk-7zWM+nE2Rg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Thanks for the review! I looked at <b925a00f4ef> and rebased the patch
on current master, ac5bdf6.
I introduced a new test file because this bug is specifically about
EXPLAIN output (as opposed to query execution or planning
functionality), and it didn't seem like a test would fit in any of the
other files. I focused on testing just the behavior around this
specific bug (and fix). I think eventually we should probably test
other more fundamental EXPLAIN features (and I'm happy to contribute
to that) in that file, but that seems outside of the scope of this
patch.
Any thoughts on what we should do with text mode output (which is
untouched right now)? The output Andres proposed above makes sense to
me, but I'd like to get more input.
| Attachment | Content-Type | Size |
|---|---|---|
| merge-explain-worker-output-v2.patch | text/x-patch | 18.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2020-01-15 07:27:02 | Re: aggregate crash |
| Previous Message | Michael Paquier | 2020-01-15 06:44:38 | Re: Remove libpq.rc, use win32ver.rc for libpq |