| From: | Dharin Shah <dharinshah95(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | [PATCH] tests: verify renamed index functionality in alter_table |
| Date: | 2026-01-02 23:13:36 |
| Message-ID: | CAOj6k6f5nmzV-tudS=jvtPEn+-c54NzVmW3usV70DiMT8YqytQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello,
The alter_table test has a FIXME saying the index rename test should verify
the index still works afterward. Currently it only checks that ALTER INDEX
RENAME succeeds, not that the renamed index is usable.
-- ALTER TABLE ... RENAME on non-table relations
-- renaming indexes (FIXME: this should probably test the index's
> functionality)
This patch adds a simple verification: EXPLAIN to show the planner finds
the index, and a SELECT to confirm it returns correct data. Uses the
standard enable_seqscan/bitmapscan/indexonlyscan=off pattern to force a
stable Index Scan across environments.
Test-only change. Verified with:
- make check TESTS=alter_table # passes
- make check # all 236 tests pass
Thanks,
Dharin
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-tests-Add-functionality-verification-for-renamed-ind.patch | application/octet-stream | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jelte Fennema-Nio | 2026-01-02 23:23:37 | Re: remove pg_restrict workaround |
| Previous Message | Alexander Korotkov | 2026-01-02 22:53:56 | Re: Implement waiting for wal lsn replay: reloaded |