Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts

From: surya poondla <suryapoondla4(at)gmail(dot)com>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rogers Wang <rogers(dot)ww(at)qq(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Andres Freund <andres(at)anarazel(dot)de>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Subject: Re: WAL_LOG CREATE DATABASE strategy broken for non-standard page layouts
Date: 2026-11-16 21:52:46
Message-ID: CAOVWO5oi463OVEdo1_wAARt=EmbFPW9nZy1__XMPR1va9tmr1Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Melanie,

Thanks for v3 and for adding the all-frozen check.

v3 looks good.

A few small comments:
1. In 0002, tablecmds.c already includes catalog/pg_am.h, which exports
catalog/pg_am_d.h, so the added #include "catalog/pg_am_d.h" is redundant.

2. For the back-branch wrapper of CreateAndCopyRelationData(), I'd
suggest it pass false for the main fork. For an unknown caller that is
always correct, the all-zeroes check still keeps the saving
whenever the hole is actually zero, and the non-main forks are handled
correctly either way.

Regards,
Surya Poondla

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tristan Partin 2026-11-16 22:02:05 Re: Add malloc attribute to memory allocation functions
Previous Message Zsolt Parragi 2026-11-16 21:50:53 Re: ORDER BY ALL