| From: | Beena Emerson <memissemerson(at)gmail(dot)com> |
|---|---|
| To: | Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: increasing the default WAL segment size |
| Date: | 2017-02-24 07:17:00 |
| Message-ID: | CAOG9ApHzCikWoEPrTQiMdiPh4Mif0ikAgF1tzapBw-9moRk3pQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 20, 2017 at 2:47 PM, Beena Emerson <memissemerson(at)gmail(dot)com>
wrote:
> Hello,
>
> On Thu, Feb 16, 2017 at 3:37 PM, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>
> wrote:
>
>> On Mon, Feb 6, 2017 at 11:09 PM, Beena Emerson <memissemerson(at)gmail(dot)com>
>> wrote:
>> >
>> > Hello,
>> > PFA the updated patches.
>> I've started reviewing the patches.
>> 01-add-XLogSegmentOffset-macro.patch looks clean to me. I'll post my
>> detailed review after looking into the second patch. But, both the
>> patches needs a rebase based on the commit 85c11324cabaddcfaf3347df7
>> (Rename user-facing tools with "xlog" in the name to say "wal").
>>
>>
>
> PFA the rebased patches.
>
>
> Hello,
The recent commit c29aff959dc64f7321062e7f33d8c6ec23db53d has again
changed the code and the second patch cannot be applied cleanly. Please
find attached the rebased 02 patch. 01 patch is the same .
--
Thank you,
Beena Emerson
Have a Great Day!
| Attachment | Content-Type | Size |
|---|---|---|
| 01-add-XLogSegmentOffset-macro.patch | application/octet-stream | 16.5 KB |
| 02-initdb-walsegsize-v2.patch | application/octet-stream | 33.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2017-02-24 07:25:16 | Re: Poor memory context performance in large hash joins |
| Previous Message | Robert Haas | 2017-02-24 07:15:42 | Re: Make subquery alias optional in FROM clause |