| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Hypothetical indexes using BRIN broken since pg10 |
| Date: | 2019-09-25 05:03:52 |
| Message-ID: | CAOBaU_azskkkhTgBxWAQ_8Hx8Kb9qHHMn2Te-XnURThJFgHbMg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 24, 2019 at 11:53 PM Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
>
> I think the danger is what happens if a version of your plugin that was
> compiled with the older definition runs in a Postgres which has been
> recompiled with the new code. This has happened to me with previous
> unnoticed ABI breaks, and it has resulted in crashes in production
> systems. It's not a nice situation to be in.
Indeed.
> If the break is benign, i.e. "nothing happens", then it's possibly a
> worthwhile change to consider. I suppose the only way to know is to
> write patches for both sides and try it out.
IIUC, if something like Heikki's patch is applied on older branch the
problem will be magically fixed from the extension point of view so
that should be safe (an extension would only need to detect the minor
version to get a more useful error message for users), and all
alternatives are too intrusive to be patckbatched.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2019-09-25 05:19:17 | Re: allow online change primary_conninfo |
| Previous Message | Michael Paquier | 2019-09-25 05:02:03 | Re: Cache lookup errors with functions manipulation object addresses |