| From: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | Hüseyin Demir <huseyin(dot)d3r(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Don't keep closed WAL segment in page cache after replay |
| Date: | 2026-03-04 07:38:24 |
| Message-ID: | CAO6_XqoDPt9+VOGkVHx5QsaBZjL7OQVhnkwb+rmtRq3pdm-ojw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 4, 2026 at 2:40 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
> Both "Return ..." and "Returns ..." styles exist in the PostgreSQL codebase,
> but within the same patch, would it be better to use a consistent style?
That makes sense, I've updated the comment. I think I usually look
around the code to copy the comments' style, but as you said, both are
present in PostgreSQL codebase.
Regards,
Anthonin Bonnefoy
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Don-t-keep-closed-WAL-segments-in-page-cache-afte.patch | application/octet-stream | 8.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2026-03-04 08:00:00 | Re: BUG: Former primary node might stuck when started as a standby |
| Previous Message | shveta malik | 2026-03-04 07:35:59 | Re: Improve pg_sync_replication_slots() to wait for primary to advance |