Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting

From: 쿼리트릭스 <querytricks2023(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: Cary Huang <cary(dot)huang(at)highgo(dot)ca>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [ psql - review request ] review request for \d+ tablename, \d+ indexname indenting
Date: 2023-09-19 00:19:34
Message-ID: CAO5pyYMnKuKhe++atnQM2w6S5B_rTYeK0ooM0+3jrCzV5gNrvw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The error was corrected and a new diff file was created.
The diff file was created based on 16 RC1.
We confirmed that 5 places where errors occurred when performing make check
were changed to ok.

Team Query Tricks
---------------------------------------
querytricks2023.gmail.com
Query Tricks(https://github.com/Query-Tricks)

2023년 9월 13일 (수) 오후 10:48, Peter Eisentraut <peter(at)eisentraut(dot)org>님이 작성:

> On 12.09.23 09:27, 쿼리트릭스 wrote:
> > Thank you for letting me know more about the test method.
> > As you said, we applied the patch using git diff and created a test case
> > on the src/test/regress/sql.
>
> Because of the change of the psql output, a lot of existing test cases
> are now failing. You should run "make check" and fix up the failures.
> Also, your new test file "subpartition_indentation" isn't actually run
> because it was not added to src/test/regress/parallel_schedule. I
> suspect you probably don't want to add a new test file for this but
> instead see if the existing tests cover this case.
>
>

Attachment Content-Type Size
psql-slashDplus-partition-indentation.diff application/octet-stream 43.1 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-09-19 00:54:54 Re: Fix error handling in be_tls_open_server()
Previous Message Peter Geoghegan 2023-09-18 23:58:47 Re: Optimizing "boundary cases" during backward scan B-Tree index descents