From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
---|---|
To: | Dave Page <dpage(at)pgadmin(dot)org> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: Fixed FB 20417 |
Date: | 2012-01-10 09:01:24 |
Message-ID: | CANxoLDf5VGFRaOLunSH9Hn3HbL9Y2vnVc3qKdkxUiYHwjJp2aQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Hi Dave
Modified the logic. Attached is the patch file, please review it.
On Mon, Jan 9, 2012 at 6:04 PM, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> On Mon, Jan 9, 2012 at 11:23 AM, Akshay Joshi
> <akshay(dot)joshi(at)enterprisedb(dot)com> wrote:
> > Hi Dave
> >
> > I have fixed the Fogbugz 20417 "PEM client: Unable to remove comments on
> > slony Replication(edb_cluster) tab". Attached is the patch file, please
> > review it.
>
> Hi,
>
> I think the patch is basically correct, but needs a small mod so it
> only appends the comment change if the user has actually changed it
> from the existing value to something else.
>
> Thanks!
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi
Senior Software Engineer
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
Phone: +91 20-3058-9522
Mobile: +91 976-788-8246*
Attachment | Content-Type | Size |
---|---|---|
FB_20417_v1.patch | application/octet-stream | 1.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2012-01-10 09:36:39 | Re: Fixed FB 20417 |
Previous Message | pgAdmin Trac | 2012-01-09 20:39:13 | Re: [pgAdmin III] #342: Enumerable type doesn't have all the options available on CREATE TYPE |