| From: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> |
|---|---|
| To: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
| Cc: | Tels <nospam-pg-abuse(at)bloodgate(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [WIP PATCH] Index scan offset optimisation using visibility map |
| Date: | 2018-03-10 14:20:01 |
| Message-ID: | CANtu0oiYC4Y0Ctk8DUrEM4woZUgVyoH0G3jQ=nzVR2Ftv0aNQQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello.
Andrey, Tels - thanks for review.
> It could be named "SkipTuples" (e.g. this is the number of tuples we need
> to skip, not the number we have skipped), and the other one then
> "iss_SkipTuplesRemaining" so they are consistent with each other.
Agreed, done.
> Also, I think that this check could be removed from loop. We do not
expect that it's state will change during execution, do we?
Removed.
Patch is attached, github is updated too.
Michail.
| Attachment | Content-Type | Size |
|---|---|---|
| offset_index_only_v4.patch | application/octet-stream | 15.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2018-03-10 14:49:04 | Re: [HACKERS] GUC for cleanup indexes threshold. |
| Previous Message | Tomas Vondra | 2018-03-10 14:05:11 | Re: [HACKERS] PATCH: multivariate histograms and MCV lists |