| From: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> |
|---|---|
| To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Antonin Houska <ah(at)cybertec(dot)at>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Full support for index LP_DEAD hint bits on standby |
| Date: | 2022-03-31 23:58:37 |
| Message-ID: | CANtu0oi1i7t3A7dRiRghqWpTdiunORdpQ=A_W95vK9xT8Nf7cQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello, David.
Thanks for your review!
> As a specific recommendation here - submit patches with a complete commit message.
> Tweak it for each new version so that any prior discussion that informed the general design of
> the patch is reflected in the commit message.
Yes, agreed. Applied to my other patch (1).
> In terms of having room for bugs this description seems like a lot of logic to have to get correct.
Yes, it is the scary part. But it is contained in single
is_index_lp_dead_maybe_allowed function for now.
> Could we just do this first pass as:
> Enable recovery mode LP_DEAD hint bit updates after the first streamed CHECKPOINT record comes over from the primary.
> ?
Not sure, but yes, it is better to split the patch into more detailed commits.
Thanks,
Michail.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-04-01 00:01:29 | Re: [WIP] ALTER COLUMN IF EXISTS |
| Previous Message | Michail Nikolaev | 2022-03-31 23:57:44 | Re: [PATCH] Full support for index LP_DEAD hint bits on standby |