| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: How can end users know the cause of LR slot sync delays? |
| Date: | 2025-11-26 04:00:15 |
| Message-ID: | CANhcyEVNZvY1Q-YGa9R=-QXOxAG4cJdjm2DpyPrqV7-mPESrcA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, 26 Nov 2025 at 09:00, Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear Hou,
>
> > I think we did not sync slots to standby2, so I removed the checks for that.
> >
> > I also adjusted the test in a way that it cleans up existing slots before starting
> > new tests.
>
> Thanks for updating the patch. I confirmed on my env that your patch could be
> applied cleanly and tests were passed. Pgperltidy say nothing for your patch.
> Also, I preferred the current style.
>
> I think it is worth checking on BF to see how they say.
>
Thanks Amit for pushing the 0001 patch.
Thanks Hou-san and Kuroda-san on fixing the test.
I have rebased the 0002 patch on the current HEAD.
Thanks,
Shlok Kyal
| Attachment | Content-Type | Size |
|---|---|---|
| v12-0001-Add-slotsync_skip_reason-to-pg_replication_slots.patch | application/octet-stream | 15.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-11-26 04:18:35 | Re: [PATCH] Add mssql_compat extension with DATEDIFF function |
| Previous Message | Michael Paquier | 2025-11-26 03:43:01 | Re: BUG #19095: Test if function exit() is used fail when linked static |