| From: | Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Include sequences in publications created by pg_createsubscriber |
| Date: | 2026-07-06 08:00:41 |
| Message-ID: | CANhcyEV-B0FzrZThZ3XAd0x5ZTj5BFfHQQ3OrHAJSTzeEJQzSQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 2 Jul 2026 at 11:59, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> wrote:
>
> >
> > The attached v6 version patch has the changes for the same.
> >
> Hi Vignesh,
>
> I reviewed the v6 patch and tested it manually for some scenarios. It
> is working fine.
> And the patch mostly looks good to me.
>
> A minor comment:
> pg_perltidy run is required on the 040_pg_createsubscriber.pl patch.
>
I ran pg_perltidy on the 040_pg_createsubscriber.pl file and attached
the updated v7 version of patch.
Thanks
Shlok Kyal
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Include-sequences-in-publications-created-by-pg_c.patch | application/octet-stream | 8.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nazir Bilal Yavuz | 2026-07-06 08:05:31 | Re: ci: namespace ccache by PostgreSQL major version |
| Previous Message | Peter Smith | 2026-07-06 07:55:19 | Re: Support EXCEPT for TABLES IN SCHEMA publications |