Re: Review: Non-inheritable check constraints

> I had a look at this patch today. The pg_dump bits conflict with
> another patch I committed a few days ago, so I'm about to merge them.
> I have one question which is about this hunk:
>
>
Thanks for taking a look Alvaro.

> @@ -2312,6 +2317,11 @@ MergeWithExistingConstraint(Relation rel, char
> *ccname, Node *expr,
> con->conislocal = true;
> else
> con->coninhcount++;
> + if (is_only)
> + {
> + Assert(is_local);
> + con->conisonly = true;
> + }
> simple_heap_update(conDesc, &tup->t_self, tup);
> CatalogUpdateIndexes(conDesc, tup);
> break;
>
>
> Is it okay to modify an existing constraint to mark it as "only", even
> if it was originally inheritable? This is not clear to me. Maybe the
> safest course of action is to raise an error. Or maybe I'm misreading
> what it does (because I haven't compiled it yet).
>
>
Hmmm, good question. IIRC, the patch will pass is_only as true only if it
going to be a locally defined, non-inheritable constraint. So I went by the
logic that since it was ok to merge and mark a constraint as locally
defined, it should be ok to mark it non-inheritable from this moment on
with that new local definition?

Regards,
Nikhils

Regards,
Nikhils