| From: | Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
|---|---|
| To: | Maxim Orlov <orlovmg(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add 64-bit XIDs into PostgreSQL 15 |
| Date: | 2022-01-06 10:24:09 |
| Message-ID: | CANbhV-FE6RUui4+mYdodVTjf2evaDF+emQJQs=xr7y7qXUuM-A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 30 Dec 2021 at 13:19, Maxim Orlov <orlovmg(at)gmail(dot)com> wrote:
> Your opinions are very much welcome!
This is a review of the Int64 options patch,
"v6-0001-Add-64-bit-GUCs-for-xids.patch"
Applies cleanly, with some fuzz, compiles cleanly and passes make check.
Patch eyeballs OK, no obvious defects.
Tested using the attached test, so seems to work correctly.
On review of docs, no additions or changes required.
Perhaps add something to README? If so, minor doc patch attached.
Otherwise, this sub-patch is READY FOR COMMITTER.
--
Simon Riggs http://www.EnterpriseDB.com/
| Attachment | Content-Type | Size |
|---|---|---|
| int64opts_test.patch | application/octet-stream | 1.5 KB |
| int64_minor_README.v1.patch | application/octet-stream | 603 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Japin Li | 2022-01-06 10:50:45 | Re: Index-only scan for btree_gist turns bpchar to char |
| Previous Message | Amit Kapila | 2022-01-06 09:41:30 | Re: Column Filtering in Logical Replication |