| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, root <tenistarkim(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Subject: | Re: centralize CPU feature detection |
| Date: | 2026-02-23 15:32:50 |
| Message-ID: | CANWCAZbKQ2im1r4ztcyfqNh_6gaJzyewabExYrkACNvMNyqxog@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Feb 20, 2026 at 3:26 PM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> 1-3 looks good to me, other than the need for the proper commit messages.
I've committed 0001.
> There's a typo in " Are ZMM registeres enabled?" in 3.
Fixed. 0002 and 0003 are attached with draft commit messages. There
was also a cosmetic mistake in an enum member name, whose correction
was squashed in the wrong direction -- this has been fixed. I also
added the new typedef for pgindent and restored a lost comment for
pg_comp_crc32c_choose(). This seems committable, but will double-check
everything works correctly.
--
John Naylor
Amazon Web Services
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0002-Centralize-detection-of-x86-CPU-features.patch | text/x-patch | 10.9 KB |
| v5-0003-Refactor-detection-of-x86-ZMM-registers.patch | text/x-patch | 2.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2026-02-23 15:43:43 | Re: Moving the vacuum GUCs' docs out of the Client Connection Defaults section |
| Previous Message | Nathan Bossart | 2026-02-23 15:27:17 | Re: refactor architecture-specific popcount code |